[
https://issues.apache.org/jira/browse/HDDS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555826#comment-16555826
]
Hudson commented on HDDS-288:
-----------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14639 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/14639/])
HDDS-288. Fix bugs in OpenContainerBlockMap. Contributed by Tsz Wo (nanda: rev
3c4fbc635e8ed81cfbec00793a3767bb47f6d176)
* (edit)
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
* (edit)
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/OpenContainerBlockMap.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestCloseContainerHandler.java
> Fix bugs in OpenContainerBlockMap
> ---------------------------------
>
> Key: HDDS-288
> URL: https://issues.apache.org/jira/browse/HDDS-288
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-288.20180724.patch
>
>
> - OpenContainerBlockMap should not be synchronized for a better performance.
> - addChunkToMap may add the same chunk twice. See the comments below.
> {code}
> keyDataSet.putIfAbsent(blockID.getLocalID(), getKeyData(info,
> blockID)); // (1) when id is absent, it puts
> keyDataSet.computeIfPresent(blockID.getLocalID(), (key, value) -> { //
> (2) now, the id is present, it adds again.
> value.addChunk(info);
> return value;
> });
> {code}
> - In removeContainer(..), use remove(..) instead of computeIfPresent(..).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
