[
https://issues.apache.org/jira/browse/HDDS-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556082#comment-16556082
]
Xiaoyu Yao commented on HDDS-245:
---------------------------------
Thanks [~elek] for the patch. It looks pretty good to me. Below are my comments
based on patch v2:
ContianerReportHandler.java
Line 93-95: should we consolidate this inside node2ContainerMap.processReport()?
After second thoughts, I think a better place might be updating the
DN2ContainerMap after we emit the replication requestat line 108.
Node2ContainerMap.java
Line 134/140: we need to check if currentSet is null before invoke removeAll to
avoid NPE or use the computeIfPresent?
Node2ContainerMapTest.java should be renamed to TestNode2ContainerMap.java
TestContainerReportHandler.java
Line 127:130: NIT: unused can be removed.
StorageContainerManager.java
Line 234: this can be removed, the handler has already been added on line 228.
ReplicationActivityStatus.java
Line 61: I did not follow this. Can you elaborate on this or add some TODO to
fix it later?
> Handle ContainerReports in the SCM
> ----------------------------------
>
> Key: HDDS-245
> URL: https://issues.apache.org/jira/browse/HDDS-245
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-245.001.patch, HDDS-245.002.patch,
> HDDS-245.003.patch
>
>
> HDDS-242 provides a new class ContainerReportHandler which could handle the
> ContainerReports from the SCMHeartbeatDispatchere.
> HDDS-228 introduces a new map to store the container -> datanode[] mapping
> HDDS-199 implements the ReplicationManager which could send commands to the
> datanodes to copy the datanode.
> To wire all these components, we need to put implementation to the
> ContainerReportHandler (created in HDDS-242).
> The ContainerReportHandler should process the new ContainerReportForDatanode
> events, update the containerStateMap and node2ContainerMap and calculate the
> missing/duplicate containers and send the ReplicateCommand to the
> ReplicateManager.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
