[
https://issues.apache.org/jira/browse/HDDS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558117#comment-16558117
]
Elek, Marton commented on HDDS-219:
-----------------------------------
Thanks [~Sandeep Nemuri] the patch. Overall it looks good to me.
1. The patch introduces two versions (ozone and hdds version). Currently hdds
and ozone versions are the same and we use just one version in the maven
(hdds.version) but later it could be separated. I am happy with this approach,
but it could be more confusing (but worst case we can hide one of the versions
from the ui/output). [~anu]: Do you have any thoughts against maintaining two
versions (hdds + ozone)
2. Yes, improving the output would be super cool...
3. We can also print out the hadoop version in 'ozone version' (good to know
which hadoop version is used as we plan to use container-service with older
hadoop versions)
4. I was not familiar the checksum part until now but I checked the source
code. It seems that the hadoop-maven-plugin does a checksum from the included
sources. As it's a generic hdds/ozone version I would consider to include all
of the hdds/ozone sources in the checksum (except the generated java files) not
just from the ozone/hdds common project. It would help to detect any local code
change. Ideally we should get the same hash code checking out the same code
base, but getting a different hash in any java/protobuf change).
5. After this patch we need to think about
org.apache.hadoop.hdds.server.ServiceRuntimeInfo and add the multiple version
to the hdds/ozone implementation of this class. (in seperated jira)
6. Just a note: The patch includes some very minor code duplication
(OzoneVersion.java/HddsVersion.java). I am happy with it. The classes are
simple, and it could be more important to avoid additional dependencies between
the projects.
> Genearate version-info.properties for hadoop and ozone
> ------------------------------------------------------
>
> Key: HDDS-219
> URL: https://issues.apache.org/jira/browse/HDDS-219
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Sandeep Nemuri
> Priority: Major
> Labels: newbie
> Fix For: 0.2.1
>
> Attachments: HDDS-219.001.patch
>
>
> org.apache.hadoop.util.VersionInfo provides an api to show the actual version
> information.
> We need to generate hdds-version-info.properties and
> ozone-version-info.properties as part of the build process(most probably in
> hdds/common, ozone/common projects) and print out the available versions in
> case of 'ozone version' command
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
