[ 
https://issues.apache.org/jira/browse/HDDS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559179#comment-16559179
 ] 

Mukul Kumar Singh commented on HDDS-226:
----------------------------------------

Thanks for working on this  [~shashikant]. Apart from Ni

1) OmKeyInfo#updateBlockLength, there are 2 for loops. Normally, the order of 
the blocks in the ksmKeyLocations and in the blockIDList will be the same, so I 
feel this can be optimized by walking the list only once. Also once we have 
found a match, we should break from the first loop.

2) Also we have a DatanodeBlockID in DatanodeContainerProto, the block length 
is not an argument there. Should this be updated as well ?

> Client should update block length in OM while committing the key
> ----------------------------------------------------------------
>
>                 Key: HDDS-226
>                 URL: https://issues.apache.org/jira/browse/HDDS-226
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Manager
>            Reporter: Mukul Kumar Singh
>            Assignee: Shashikant Banerjee
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-226.00.patch, HDDS-226.01.patch, HDDS-226.02.patch, 
> HDDS-226.03.patch, HDDS-226.04.patch, HDDS-226.05.patch
>
>
> Currently the client allocate a key of size with SCM block size, however a 
> client can always write smaller amount of data and close the key. The block 
> length in this case should be updated on OM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to