[
https://issues.apache.org/jira/browse/HDFS-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559183#comment-16559183
]
Xiao Chen commented on HDFS-13658:
----------------------------------
Thanks for the continued work on this Kitti! I think this is pretty close, some
comments:
- For EC blocks, low redundancy is not having 0 or 1 replicas. I guess we could
borrow from the comment of {{LowRedundancyBlocks#getPriorityStriped}}, to call
it 'at highest risk of loss'.
- {{ECBlockGroupStats}} and {{ReplicatedBlockStats}} are public, so we cannot
change the constructors. Can either add an overload ctor, or add use builder
pattern if you want.
- I think don't feel strongly about the new fsck option. But for cleanness I
propose we do the metrics work here, and split that out to another jira. My
take is that with the new stats admins can get the information they want, and
the fsck flag seems to add limited value.
> fsck, dfsadmin -report, and NN WebUI should report number of blocks that have
> 1 replica
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-13658
> URL: https://issues.apache.org/jira/browse/HDFS-13658
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.1.0
> Reporter: Kitti Nanasi
> Assignee: Kitti Nanasi
> Priority: Major
> Attachments: HDFS-13658.001.patch, HDFS-13658.002.patch,
> HDFS-13658.003.patch, HDFS-13658.004.patch, HDFS-13658.005.patch,
> HDFS-13658.006.patch, HDFS-13658.007.patch, HDFS-13658.008.patch
>
>
> fsck, dfsadmin -report, and NN WebUI should report number of blocks that have
> 1 replica. We have had many cases opened in which a customer has lost a disk
> or a DN losing files/blocks due to the fact that they had blocks with only 1
> replica. We need to make the customer better aware of this situation and that
> they should take action.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]