[ 
https://issues.apache.org/jira/browse/HDDS-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559787#comment-16559787
 ] 

Anu Engineer commented on HDDS-293:
-----------------------------------

+1, only thing that is not clear how much memory saving are we looking at? Is 
it that we have very large number of keys with single blocks and this patch is 
useful in those cases. As I said, I am +1, please feel free to commit. There 2 
minor checkStyle issues in the Test file, a white space after ';' in line 58 
and line 63, CheckStyle does not like the variable name in caps. Please feel 
free to fix them while committing.

> Reduce memory usage in KeyData
> ------------------------------
>
>                 Key: HDDS-293
>                 URL: https://issues.apache.org/jira/browse/HDDS-293
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-293.20180726.patch
>
>
> Currently, the field chunks is declared as a List<ChunkInfo> in KeyData as 
> shown below.
> {code}
> //KeyData.java
>   private List<ContainerProtos.ChunkInfo> chunks;
> {code}
> It is expected that many KeyData objects only have a single chunk.  We could 
> reduce the memory usage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to