[ 
https://issues.apache.org/jira/browse/HDDS-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559793#comment-16559793
 ] 

Allen Wittenauer commented on HDDS-276:
---------------------------------------

Nope, -1 on this patch too.

This patch pretty much breaks a very common operational practice for the sole 
purpose of making testing easier. If I extract a tarball, I'm expecting to get 
'project-version'.  There is a very good chance users are going to do this in a 
dir with multiple versions extracted with their own symlink set.

Again, there seems to be a desire to trade simpler testing logic for a more 
difficult and surprising operational experience.  

> Fix symbolic link creation during Ozone dist process
> ----------------------------------------------------
>
>                 Key: HDDS-276
>                 URL: https://issues.apache.org/jira/browse/HDDS-276
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>    Affects Versions: 0.2.1
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Minor
>             Fix For: 0.2.1
>
>         Attachments: HDDS-276.001.patch
>
>
> Ozone is creating a symlink during the dist process.
> Using the "ozone" directory as a destination name all the docker-based 
> acceptance tests and docker-compose files are more simple as they don't need 
> to have the version information in the path.
> But to keep the version specific folder name in the tar file we create a 
> symbolic link during the tar creation. With the symbolic link and the 
> '–dereference' tar argument we can create the tar file which includes a 
> versioned directory (ozone-0.2.1) but we can use the a dist directory without 
> the version in the name (hadoop-dist/target/ozone).
> Currently this symlink creation has an issue. It couldn't be run twice. You 
> need to do a 'mvn clean' before you can create a new dist.
> But fortunately this could be fixed easily by checking if the destination 
> symlink exists.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to