[ 
https://issues.apache.org/jira/browse/HDDS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563184#comment-16563184
 ] 

Lokesh Jain commented on HDDS-283:
----------------------------------

[~nilotpalnandi] Thanks for working on this! The patch looks very good to me. 
Please find my comments below.
 # ListVolumeHandler: 93-95 - I think we should have the default implementation 
to set userName to the user invoking the shell command. And we can use 
Shell.RUNAS to specify the root privileges to the user. If Shell.RUNAS is 
provided we can set the userName to null.
 # ListVolumeHandler: 114-120 - The statements exceed the 80 character length 
limit.
 # RestClient:372-376- We may not need to specify a different authorization? 
The currentUser is enough.
 # TestBlockDeletingService - changes are not related.

> Need an option to list all volumes created in the cluster
> ---------------------------------------------------------
>
>                 Key: HDDS-283
>                 URL: https://issues.apache.org/jira/browse/HDDS-283
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Client
>            Reporter: Nilotpal Nandi
>            Assignee: Nilotpal Nandi
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-283.001.patch
>
>
> Currently , listVolume command either gives :
> 1) all the volumes created by a particular user , using -user argument.
> 2) or , all the volumes created by the logged in user , if no -user argument 
> is provided.
>  
> We need an option to list all the volumes created in the cluster



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to