[
https://issues.apache.org/jira/browse/HDDS-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564365#comment-16564365
]
Ajay Kumar commented on HDDS-298:
---------------------------------
[~msingh] thanks for review.
{quote}1) ContainerMapping:208, I feel this line should be removed as call to
getReplicationPipeline will create a new pipeline.
2) ContainerMapping:475, this call should be removed as well. This change isn't
part of this patch, but can be removed
3) ContainerMapping: 532, this line should be removed as well because of above
reason.
I feel that getReplicationPipeline should only be called while allocating
containers.{quote}
In all these 3 cases calling getReplicationPipeline is fallback option in case
pipeline is not found in current data structures in memory.(considering SCM
restart and other similar scenarios) Removing it will not only involve a more
widespread change where we will get NPE for pipeline but also will require
clients to make another RPC to get pipeline.
> Implement SCMClientProtocolServer.getContainerWithPipeline for closed
> containers
> --------------------------------------------------------------------------------
>
> Key: HDDS-298
> URL: https://issues.apache.org/jira/browse/HDDS-298
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Ajay Kumar
> Priority: Critical
> Fix For: 0.2.1
>
> Attachments: HDDS-298.00.patch, HDDS-298.01.patch
>
>
> As [~ljain] mentioned during the review of HDDS-245
> SCMClientProtocolServer.getContainerWithPipeline doesn't return with good
> data for closed containers. For closed containers we are maintaining the
> datanodes for a containerId in the ContainerStateMap.contReplicaMap. We need
> to create fake Pipeline object on-request and return it for the client to
> locate the right datanodes to download data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
