[
https://issues.apache.org/jira/browse/HDDS-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564559#comment-16564559
]
genericqa commented on HDDS-284:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 13 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
41s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 29m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 31m
37s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
17m 8s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
27s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 30m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 30m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 30m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4m
42s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 51s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hadoop-ozone/integration-test {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
27s{color} | {color:red} hadoop-hdds/common generated 4 new + 0 unchanged - 0
fixed = 4 total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
51s{color} | {color:red} hadoop-ozone/tools generated 1 new + 0 unchanged - 0
fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
6s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
52s{color} | {color:green} container-service in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
35s{color} | {color:green} client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} ozone-manager in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
35s{color} | {color:green} objectstore-service in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
32s{color} | {color:green} tools in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 15s{color}
| {color:red} integration-test in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
48s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}182m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdds/common |
| | Dead store to checkSumBlockSize in
org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.readSmallFile(XceiverClientSpi,
BlockID, String) At
ContainerProtocolCalls.java:org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.readSmallFile(XceiverClientSpi,
BlockID, String) At ContainerProtocolCalls.java:[line 407] |
| | Dead store to checkSumType in
org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.readSmallFile(XceiverClientSpi,
BlockID, String) At
ContainerProtocolCalls.java:org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.readSmallFile(XceiverClientSpi,
BlockID, String) At ContainerProtocolCalls.java:[line 410] |
| | Dead store to verifyCheckSum in
org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.readSmallFile(XceiverClientSpi,
BlockID, String) At
ContainerProtocolCalls.java:org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.readSmallFile(XceiverClientSpi,
BlockID, String) At ContainerProtocolCalls.java:[line 413] |
| | Dead store to verifyCheckSum in
org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.writeSmallFile(XceiverClientSpi,
BlockID, byte[], String) At
ContainerProtocolCalls.java:org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.writeSmallFile(XceiverClientSpi,
BlockID, byte[], String) At ContainerProtocolCalls.java:[line 248] |
| FindBugs | module:hadoop-ozone/tools |
| | Useless object stored in variable dataString of method
org.apache.hadoop.ozone.genesis.BenchMarkDatanodeDispatcher.getWriteChunkCommand(BlockID,
String) At BenchMarkDatanodeDispatcher.java:dataString of method
org.apache.hadoop.ozone.genesis.BenchMarkDatanodeDispatcher.getWriteChunkCommand(BlockID,
String) At BenchMarkDatanodeDispatcher.java:[line 182] |
| Failed junit tests |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
|
| | hadoop.ozone.ozShell.TestOzoneShell |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 |
| JIRA Issue | HDDS-284 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12933822/HDDS-284.01.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle cc xml |
| uname | Linux 6c8bc17d23df 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 4b540bb |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| whitespace |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/artifact/out/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/artifact/out/whitespace-tabs.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/artifact/out/new-findbugs-hadoop-hdds_common.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/artifact/out/new-findbugs-hadoop-ozone_tools.html
|
| unit |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 2475 (vs. ulimit of 10000) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/client hadoop-ozone/client hadoop-ozone/ozone-manager
hadoop-ozone/objectstore-service hadoop-ozone/tools
hadoop-ozone/integration-test U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDDS-Build/675/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Interleaving CRC for ChunksData
> -------------------------------
>
> Key: HDDS-284
> URL: https://issues.apache.org/jira/browse/HDDS-284
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Fix For: 0.3.0
>
> Attachments: HDDS-284.00.patch, HDDS-284.01.patch, Interleaving CRC
> and Error Detection for Containers.pdf
>
>
> This Jira is to add CRC for chunks data.
> Right now, in chunkInfo, data is just byte array. We want to change this as
> below:
> _message Data {_
> _required string magic =”Tullys00” = 1;_
> _required CRCTYPE crcType =_ _2__;_
> _optional String LegacyMetadata = 3; // Fields to support inplace data
> migration_
> _optional String LegacyData = 4;_
> _optional ushort ChecksumblockSize = 5; // Size of the block used to compute
> the checksums_
> _repeated uint32 checksums = 6 ; // Set of Checksums_
> *_repeated byte data = 6;_* _// Actual Data stream_
>
> _}_
>
> _This will help in error detection for containers during container scanner._
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
