[ 
https://issues.apache.org/jira/browse/HDFS-13792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569462#comment-16569462
 ] 

Yiqun Lin commented on HDFS-13792:
----------------------------------

Good catch, [~csun]. The patch LGTM. One minor comment: would you mind adding 
the missing overall metric of fsn lock that added in HDFS-13686? It's okay to 
fix this as well in this JIRA I think, just a minor change. 

> Fix FSN read/write lock metrics name
> ------------------------------------
>
>                 Key: HDFS-13792
>                 URL: https://issues.apache.org/jira/browse/HDFS-13792
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: documentation, metrics
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>            Priority: Trivial
>         Attachments: HDFS-13792.000.patch
>
>
> The metrics name for FSN read/write lock should be in the format:
> {code}
> FSN(Read|Write)Lock`*OperationName*`NanosNumOps
> {code}
> not
> {code}
> FSN(Read|Write)Lock`*OperationName*`NumOps
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to