[
https://issues.apache.org/jira/browse/HDFS-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072154#comment-13072154
]
Eli Collins commented on HDFS-2195:
-----------------------------------
+1 latest patch looks good
> Refactor StorageDirectory to not be an non-static inner class
> -------------------------------------------------------------
>
> Key: HDFS-2195
> URL: https://issues.apache.org/jira/browse/HDFS-2195
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: data-node, name-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-2195.txt, hdfs-2195.txt
>
>
> While working on HDFS-1073 I continually found it inconvenient that
> StorageDirectory is a non-static inner class of Storage. This makes testing
> more complicated, and also has unintuitive results, like {{sd.read()}} having
> side effects on a Storage object.
> I'd like to try to make it a static inner class so that these side effects
> are clearer and it's easier to use in isolation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
