[
https://issues.apache.org/jira/browse/HDDS-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571509#comment-16571509
]
Mukul Kumar Singh commented on HDDS-308:
----------------------------------------
Thanks for updating the patch [~ljain]. This patch looks really good to me.
Some minor comments as following.
1) ContainerMapping.java:552, getPendingDeleteStatusesCount can be renamed to
getNumPendingDeletes
2) PendingDeleteStatusList:java, lets make pendingDeleteStatuses private as well
3) SCMBlockDeletingService:110, lets change the name from handle ->
handlePendingDeletes
4) SCMEvents:151, I feel this can be renamed to PENDING_DELETE_TRANSACTION ->
PENDING_DELETE_STATUS, Also please add details about this event as well.
5) TestBlockManager#testDeleteBlock, I feel we can either remove this test, or
can add a check that entries have been added to the log. I feel we can use
getTransactions to verify that entries were added to the log.
6) TestBlockDeletion.java:155, lets add some more comments stating that this is
a re-verify after restart of dn.
7) Also lets make sure that in for open containers, this event is not triggered
and also for a happy case scenario with close containers too this event isn't
triggered.
> SCM should identify a container with pending deletes using container reports
> ----------------------------------------------------------------------------
>
> Key: HDDS-308
> URL: https://issues.apache.org/jira/browse/HDDS-308
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-308.001.patch, HDDS-308.002.patch,
> HDDS-308.003.patch, HDDS-308.004.patch
>
>
> SCM should fire an event when it finds using container report that a
> container's deleteTransactionID does not match SCM's deleteTransactionId.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
