[
https://issues.apache.org/jira/browse/HDDS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572385#comment-16572385
]
Bharat Viswanadham edited comment on HDDS-328 at 8/7/18 9:45 PM:
-----------------------------------------------------------------
Hi [~elek]
Thanks for the patch. Overall patch LGTM.
Few comments I have:
1. KeyValueContainer.java:
Line 172: Typo in the comment. realted -> related
2. In KeyValueContainer.java in importContainerData, we have to update
following fields of keyvaluecontainerdata: checksum, dbType, layoutversion and
state from original containerData.
3. Changes in KeyValueContainerData.java change only imports, this is needed
change?
4. We can use these constants from OzoneConsts.java, instead of redefining it.
As in future any of these get changed, it will be all in one place.
5. In KeyValueHandler populateContainerPathFields(), we need to acquire a
volumeSet lock, so that if some volume gets removed during chooseVolume, it
will avoid doing that.
6. Checkstyle issues in TestContainerPacker. Line 108,161 need to be uppercase
L.
7. In TestKeyValueContainer, after unpack, can we verify all the containerData
fields with newly replaced one with the old containerData fields. (Checksum no
need of comparing, as they will change)
was (Author: bharatviswa):
Hi [~elek]
Thanks for the patch. Overall patch LGTM.
Few comments I have:
1. KeyValueContainer.java:
Line 172: Typo in the comment. realted -> related
2. In KeyValueContainer.java in importContainerData, we have to update
following fields of keyvaluecontainerdata: checksum, dbType, state from
original containerData.
3. Changes in KeyValueContainerData.java change only imports, this is needed
change?
4. We can use these constants from OzoneConsts.java, instead of redefining it.
As in future any of these get changed, it will be all in one place.
5. In KeyValueHandler populateContainerPathFields(), we need to acquire a
volumeSet lock, so that if some volume gets removed during chooseVolume, it
will avoid doing that.
6. Checkstyle issues in TestContainerPacker. Line 108,161 need to be uppercase
L.
7. In TestKeyValueContainer, after unpack, can we verify all the containerData
fields with newly replaced one with the old containerData fields. (Checksum no
need of comparing, as they will change)
> Support export and import of the KeyValueContainer
> --------------------------------------------------
>
> Key: HDDS-328
> URL: https://issues.apache.org/jira/browse/HDDS-328
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Critical
> Fix For: 0.2.1
>
> Attachments: HDDS-328.002.patch
>
>
> In HDDS-75 we pack the container data to an archive file, copy to other
> datanodes and create the container from the archive.
> As I wrote in the comment of HDDS-75 I propose to separate the patch to make
> it easier to review.
> In this patch we need to extend the existing Container interface with adding
> export/import methods to save the container data to one binary input/output
> stream.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
