[
https://issues.apache.org/jira/browse/HDDS-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574324#comment-16574324
]
Mukul Kumar Singh commented on HDDS-339:
----------------------------------------
Thanks for working on this [~shashikant]. Please find my review comments as
following.
1) DatanodeContainerProtocol.proto:311, getCommittedBlockLength->
committedBlockLength
2) KeyValueHandler:43, Unused import
3) KeyValueHandler:438, I feel the length can be returned as part of
commitKey, once the key has been committed successfully, the length can be
returned.
4) KeyUtils:156, there is a unused variable here, I feel this can be removed
5) KeyUtils:140, putKeyResposne-> putKeyResponse
6) KeyUtils:130, returns putkey response success
7) KeyUtils:134, getPutKeyResponseSuccess -> putKeyResponseSuccess
8) KeyUtils:194, msg is a unused field
> Add block length and blockId in PutKeyResponse
> ----------------------------------------------
>
> Key: HDDS-339
> URL: https://issues.apache.org/jira/browse/HDDS-339
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client, Ozone Datanode
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-339.00.patch
>
>
> The putKey response will include blockId as well committed block length in
> the PutKey response. This will be extended to include blockCommitSequenceId
> as well all of which will be updated on Ozone Master. This all be required to
> add validation as well handle 2 node failure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
