Shashikant Banerjee commented on HDDS-324:

Thanks [~msingh], for working on this. The patch looks good to me overall.

Some minor comments:
 # ContainerMapping:186 : ContainerInfo contInfo -> ContainerInfo containerInfo 
(not related to this patch)
 # We may remove groupId filed from PipelineId class and construct it when its 
 # PipelineManager.java : 41 -> 
// private final List<Pipeline> activePipelines;{code}
this can be removed with List<PipelineID> activePipelines;
 # We may add some comments to clarify what groupID signify in PipelineID class.
 # Please check findbug/javadoc issues reported.

> Use pipeline name as Ratis groupID to allow datanode to report pipeline info
> ----------------------------------------------------------------------------
>                 Key: HDDS-324
>                 URL: https://issues.apache.org/jira/browse/HDDS-324
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>    Affects Versions: 0.2.1
>            Reporter: Mukul Kumar Singh
>            Assignee: Mukul Kumar Singh
>            Priority: Major
>             Fix For: 0.2.1
>         Attachments: HDDS-324.001.patch, HDDS-324.002.patch, 
> HDDS-324.003.patch, HDDS-324.004.patch, HDDS-324.005.patch, HDDS-324.006.patch
> Currently Ozone creates a random pipeline id for every pipeline where a 
> pipeline consist of 3 nodes in a ratis ring. Ratis on the other hand uses the 
> notion of RaftGroupID which is a unique id for the nodes in a ratis ring. 
> When a datanode sends information to SCM, the pipeline for the node is 
> currently identified using dn2PipelineMap. With correct use of RaftGroupID, 
> we can eliminate the use of dn2PipelineMap.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to