[ https://issues.apache.org/jira/browse/HDFS-13790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576107#comment-16576107 ]
Íñigo Goiri commented on HDFS-13790: ------------------------------------ Thanks [~csun] for [^HDFS-13790.000.patch], the refactor looks good to me. Thanks [~brahmareddy] for the comments. bq. we could have thrown "unsupported operation" or some generic message for unimplemented methods. {{checkOperation()}} with false as a parameter already reports unsupported, we should be fine there. bq. This commit should go first in this umbrella. I agree. The question at this point is if we start a branch for this umbrella or not. I'm fine either way. > RBF: Move ClientProtocol APIs to its own module > ----------------------------------------------- > > Key: HDFS-13790 > URL: https://issues.apache.org/jira/browse/HDFS-13790 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Íñigo Goiri > Assignee: Chao Sun > Priority: Major > Attachments: HDFS-13790.000.patch > > > {{RouterRpcServer}} is getting pretty long. {{RouterNamenodeProtocol}} > isolates the {{NamenodeProtocol}} in its own module. {{ClientProtocol}} > should have its own {{RouterClientProtocol}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org