[
https://issues.apache.org/jira/browse/HDFS-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578305#comment-16578305
]
Íñigo Goiri commented on HDFS-13787:
------------------------------------
Thanks [~RANith] for the patch.
A few comments:
* We will have to refactor after HDFS-13790.
* Can we remove the commented pieces of code?
* We need to manage checkOperation correctly; we should do it consistently with
ErasureCoding for example.
* Let's add javadocs in RouterSnapshot consistently to the other modules.
> RBF: Add Snapshot related ClientProtocol APIs
> ---------------------------------------------
>
> Key: HDFS-13787
> URL: https://issues.apache.org/jira/browse/HDFS-13787
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ranith Sardar
> Assignee: Ranith Sardar
> Priority: Major
> Attachments: HDFS-13787.001.patch
>
>
> Currently, allowSnapshot, disallowSnapshot, renameSnapshot, createSnapshot,
> deleteSnapshot , SnapshottableDirectoryStatus, getSnapshotDiffReport and
> getSnapshotDiffReportListing are not implemented in RouterRpcServer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
