[ https://issues.apache.org/jira/browse/HDDS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579660#comment-16579660 ]
LiXin Ge commented on HDDS-265: ------------------------------- [~ljain] Thanks for your further comments. bq. 1.We can use default keyword to provide a default implementation. Done in the v003 patch. bq.2.RandomContainerDeletionChoosingPolicy:59,60 - The change should be reverted Done in the v003 patch. bq.3.There is a compilation failure after applying the patch It's something with HDDS-308 which merged recently. Rebased in the v003 patch. bq.4.I think we can have a getContainerReport api in Container.java? Agree, it should be a global function for all kinds of container! Done in the v003 patch. > Move numPendingDeletionBlocks and deleteTransactionId from ContainerData to > KeyValueContainerData > ------------------------------------------------------------------------------------------------- > > Key: HDDS-265 > URL: https://issues.apache.org/jira/browse/HDDS-265 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Affects Versions: 0.2.1 > Reporter: Hanisha Koneru > Assignee: LiXin Ge > Priority: Major > Fix For: 0.2.1 > > Attachments: HDDS-265.000.patch, HDDS-265.001.patch, > HDDS-265.002.patch, HDDS-265.003.patch > > > "numPendingDeletionBlocks" and "deleteTransactionId" fields are specific to > KeyValueContainers. As such they should be moved to KeyValueContainerData > from ContainerData. > ContainerReport should also be refactored to take in this change. > Please refer to [~ljain]'s comment in HDDS-250. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org