[
https://issues.apache.org/jira/browse/HDDS-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580084#comment-16580084
]
Ajay Kumar commented on HDDS-298:
---------------------------------
[~xyao] thanks for review.
{code}
ContainerMapping.java
Line 79: NIT: CLOSE->CLOSED, Close-pipeline- => Closed-pipeline-{code}
With HDDS-324 we have replaced string based pipeline name with UUID based
pipelineId. So removed this name field.
{code}
Line 206-208: NIT: unrelated change {code}
removed
{code}
Line 214 getContainerReplica() returns a immutable set, we can avoid allocate a
new ArrayList for the datanodes.{code}
done!
{code}
Line 215-217: Can we fold this with a new API
containerStateManager#getContainerReplica() to avoid expose the complete
containerStateMap here?
{code}
Done. We already have an API, i think i missed it initially.
{code}
Line 221: can we define a more specific error code here?
{code}
Added NO_REPLICA_FOUND in ResultCodes but removed these lines as
ContainerStateMap#getContainerReplicas already throws an SCM exception if no
replicas are found. Updated test case to check for this exception.
{code}
Line 224: should we use a different replication type here for closed
containers?{code}
I was thinking closed container might already have STANDALONE type. Changed it
to STANDALONE explicitly.
> Implement SCMClientProtocolServer.getContainerWithPipeline for closed
> containers
> --------------------------------------------------------------------------------
>
> Key: HDDS-298
> URL: https://issues.apache.org/jira/browse/HDDS-298
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Ajay Kumar
> Priority: Critical
> Fix For: 0.2.1
>
> Attachments: HDDS-298.00.patch, HDDS-298.01.patch, HDDS-298.02.patch,
> HDDS-298.03.patch, HDDS-298.04.patch, HDDS-298.05.patch, HDDS-298.06.patch
>
>
> As [~ljain] mentioned during the review of HDDS-245
> SCMClientProtocolServer.getContainerWithPipeline doesn't return with good
> data for closed containers. For closed containers we are maintaining the
> datanodes for a containerId in the ContainerStateMap.contReplicaMap. We need
> to create fake Pipeline object on-request and return it for the client to
> locate the right datanodes to download data.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
