[ 
https://issues.apache.org/jira/browse/HDDS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580895#comment-16580895
 ] 

Elek, Marton commented on HDDS-336:
-----------------------------------

Thanks the interest [~GeLiXin].

1. It's related both to RPC and Rest interface. Both of them should be improved 
as RpcClient and RestClient share a common interface. (But it could be 
separated to two different jira-s)

2. Yes  containerid/localid would be enough. There is an ozone scmcli command 
which would give more details to a specific container id. But to use it we need 
the container id for a specific key.

3. It would be enough to print out these information for a specific keys not 
for the list of kezs. I think we can improve the RpcClient/RestClient 
getKeyDetails method with returning an OzoneKeyDetails instead of OzoneKey 
which extends the OzoneKey and contains additional information.

With this approach the listKey call will be as effective as now (no additional 
data in the response) but the getKeyDetails could give us more detailed view 
which wouldn't be a significant overhead.

4. The rpc client could be easier as the rpc call already has all the required 
information (keyInfo.getLatestVersionLocations) only the signature of the 
getKeyDetails should be improved and the data returned.

5. The rest implementation may need more work as the required data should be 
added on the server side first.

Let me know if you have additional questions.

> Print out container location information for a specific ozone key 
> ------------------------------------------------------------------
>
>                 Key: HDDS-336
>                 URL: https://issues.apache.org/jira/browse/HDDS-336
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: SCM
>            Reporter: Elek, Marton
>            Priority: Major
>              Labels: newbie
>             Fix For: 0.2.1
>
>
> In the protobuf protocol we have all the containerid/localid(=blockid) 
> information for a specific ozone key.
> It would be a big help to print out this information to the command line with 
> the ozone cli.
> It requires to improve the REST and RPC interface with additionalOzone 
> KeyLocation information.
> It would help a very big help during the test of the current scm behaviour.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to