[ 
https://issues.apache.org/jira/browse/HDFS-13634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585247#comment-16585247
 ] 

CR Hota commented on HDFS-13634:
--------------------------------

[~elgoiri] Thanks for reviewing this.

I too believe there is no unit test needed for this.

Class field is needed to help log the error scenario when more connection 
requests are getting into the queue than the capacity. This below line

LOG.error("Cannot add more than {} connections at the same time",
 MAX_NEW_CONNECTIONS);

 

> RBF: Configurable value in xml for async connection request queue size.
> -----------------------------------------------------------------------
>
>                 Key: HDFS-13634
>                 URL: https://issues.apache.org/jira/browse/HDFS-13634
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: federation
>            Reporter: CR Hota
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HDFS-13634.0.patch, HDFS-13634.1.patch
>
>
> The below in ConnectionManager.java should be configurable via hdfs-site.xml. 
> This a very critical parameter for routers, admins would like to change this 
> without doing a new build.
> {code:java}
>   /** Number of parallel new connections to create. */
>   protected static final int MAX_NEW_CONNECTIONS = 100;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to