[ 
https://issues.apache.org/jira/browse/HDFS-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079620#comment-13079620
 ] 

Todd Lipcon commented on HDFS-2225:
-----------------------------------

+1. test-patch:

     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 15 new or 
modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs 
(version 1.3.8) warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test 
framework compile.

and I ran all the unit tests that contain the word EditLog or were modified by 
this patch.

Will commit momentarily

> HDFS-2018 Part 1 : Refactor file management so its not in classes which 
> should be generic
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-2225
>                 URL: https://issues.apache.org/jira/browse/HDFS-2225
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-2225.diff, HDFS-2225.diff, HDFS-2225.diff
>
>
> This is the first part of HDFS-2018 changes, to refactor some of the file 
> management classes so they're in file specific places rather than in the 
> generic classes. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to