[
https://issues.apache.org/jira/browse/HDFS-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590482#comment-16590482
]
Íñigo Goiri edited comment on HDFS-13836 at 8/23/18 4:35 PM:
-------------------------------------------------------------
[^HDFS-13836.003.patch] LGTM.
I'm not sure if we should log some of the corrupted errors.
[~hfyang20071], you found the error, do you think it is easy to track what
happened now?
My only concern with adding logs would be to be too verbose.
Give it a thought, if this is fine, it's OK with me too.
A couple other minor comments:
* For the asserts, I think we can use {{assertNull}} and {{assertNotNull}}.
* Should we generate the fake records in a higher level way? For example,
instead of "0SLASH0node", use the mark and use the conversion to generate the
underscores.
* Missing space in line 103 of the test.
* We should do: {{String nodeName =
StateStoreUtils.getRecordName(recordClass);}}
was (Author: elgoiri):
[^HDFS-13836.003.patch] LGTM.
I'm not sure if we should log some of the corrupted errors.
[~hfyang20071], you found the error, do you think it is easy to track what
happened now?
My only concern with adding logs would be to be too verbose.
Give it a thought, if this is fine, it's OK with me too.
A couple other minor comments:
* For the asserts, I think we can use {{assertNull}} and {{assertNotNull}}.
* Should we generate the fake records in a higher level way? For example,
instead of "0SLASH0node", use the mark and use the conversion to generate the
underscores.
* Missing space in line 103 of the test.
> RBF: To handle the exception when the mounttable znode have null value.
> -----------------------------------------------------------------------
>
> Key: HDFS-13836
> URL: https://issues.apache.org/jira/browse/HDFS-13836
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: federation, hdfs
> Affects Versions: 3.1.0
> Reporter: yanghuafeng
> Assignee: yanghuafeng
> Priority: Major
> Fix For: 2.9.0, 3.0.0, 3.1.0, 3.2.0
>
> Attachments: HDFS-13836.001.patch, HDFS-13836.002.patch,
> HDFS-13836.003.patch
>
>
> When we are adding the mounttable entry, the router sever is terminated.
> Some error messages show in log, as follow:
> 2018-08-20 14:18:32,404 ERROR
> org.apache.hadoop.hdfs.server.federation.store.driver.impl.StateStoreZooKeeperImpl:
> Cannot get data for 0SLASH0testzk: null.
> The reason is that router server have created the znode but not to set data
> before being terminated. But the method zkManager.getStringData(path, stat)
> will throw NPE if the path has null value in the StateStoreZooKeeperImpl,
> leading to fail in adding the same mounttable entry and deleting the existing
> znode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
