[ 
https://issues.apache.org/jira/browse/HDFS-13810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590558#comment-16590558
 ] 

Brahma Reddy Battula commented on HDFS-13810:
---------------------------------------------

Both *update* and *add* will call *MountTable newEntry = 
MountTable.newInstance(mount, destMap);* which will validate the record. 
(update uses same as add,but update should add to existing entry,this can be 
discussed HDFS-13853 ) 

Problem here is, when we trigger *addmount* twices*,*Second time we use 
*UpdateMountTableEntryRequest* to add(mount record exists already) the record 
which will not validate the record.

To solve this,

i) we might need remove *UpdateMountTableEntryRequest from* addmount which is 
incompatiable and it's going to handle HDFS-13507.

ii) Need validate dest before passing to updatereqest Or provided patch.

IMO,HDFS-13507 should got only trunk as it's incompatible.. so we should go 
with ii) for lower.

let me know your thought.

 

>  RBF: UpdateMountTableEntryRequest isn't validating the record.
> ---------------------------------------------------------------
>
>                 Key: HDFS-13810
>                 URL: https://issues.apache.org/jira/browse/HDFS-13810
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: federation
>    Affects Versions: 3.0.0, 2.9.1
>            Reporter: venkata ram kumar ch
>            Assignee: venkata ram kumar ch
>            Priority: Minor
>         Attachments: HDFS-13810-002.patch, HDFS-13810.patch
>
>
> In RBF when we try to update the existing mount entry by using the add 
> command its creating a mount entry without performing the validation check / 
> on the destination path.
> command : ./hdfs dfsrouteradmin -add /aaa ns1 /tmp (record  added to the 
> mount table)
> Now when we use the below command on the same mount entry. 
> Command : hdfs dfsrouteradmin -add /aaa ns1  -order RANDOM  (its not 
> performing the validation check for the second time).
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to