[
https://issues.apache.org/jira/browse/HDDS-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590834#comment-16590834
]
Dinesh Chitlangia commented on HDDS-332:
----------------------------------------
[~anu] Thank you for working on this.
Could you please take a look at following:
1. StorageHandlerBuilder.getStorageHandler()
{{- Configuration conf = new OzoneConfiguration(); }}
{{- return new LocalStorageHandler(conf); }}
{{+ LOG.error("No Storage Handler Configured."); }}
{{+ throw new IOException("Invalid Handler Configuration");}}
I understand the purpose of adding these lines in the else block in case
storageHandler is null. However, since we specify distributed as the default
value for storageHandler, I am wondering if we will run into a scenario where
storageHandler is null. Is there some additional check that we must do
elsewhere to have the default value set correctly?
2. Some test classes specify OZONE_HANDLER_TYPE_KEY = "local" in comments. Do
you think it will be a good idea to see if those comments should be updated
too, to avoid any ambiguity?
Following test classes can be checked:
TestVolume.java
TestBuckets.java
TestOzoneWebAccess.java
TestOzoneLocalVolumes.java
> Remove the ability to configure ozone.handler.type
> --------------------------------------------------
>
> Key: HDDS-332
> URL: https://issues.apache.org/jira/browse/HDDS-332
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-332.001.patch
>
>
> Based on feedback from [~anu] and [~xyao], logging this Jira to remove the
> ability to configure ozone.handler.type.
> Currently, it can be configured with values - distributed or local.
> Value 'local' was strictly for internal testing purposes in initial stages.
> By removing the configurability, we can avoid situations where users may end
> up misconfiguring and running into issues.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
