[ 
https://issues.apache.org/jira/browse/HDFS-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591894#comment-16591894
 ] 

Íñigo Goiri commented on HDFS-13854:
------------------------------------

The code makes sense.

I think to prevent this from happening in the future we should add a unit test.
It's hard to check for actual values but we can check that the magnitude is 
correct.
However, from the screenshots, I think we can assume that some operations will 
take ms and not seconds.

> RBF: The ProcessingAvgTime and ProxyAvgTime should display by JMX with ms 
> unit.
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-13854
>                 URL: https://issues.apache.org/jira/browse/HDFS-13854
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: federation, hdfs
>    Affects Versions: 2.9.0, 3.0.0, 3.1.0
>            Reporter: yanghuafeng
>            Assignee: yanghuafeng
>            Priority: Major
>         Attachments: HDFS-13854.001.patch, HDFS-13854.002.patch, 
> ganglia_jmx_compare1.jpg, ganglia_jmx_compare2.jpg
>
>
> In the FederationRPCMetrics, proxy time and processing time should be exposed 
> to the jmx or ganglia with ms units. Although the method toMS() exists, we 
> cannot get the correct proxy time and processing time by jmx and ganglia.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to