[
https://issues.apache.org/jira/browse/HDDS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592528#comment-16592528
]
Mukul Kumar Singh commented on HDDS-247:
----------------------------------------
Thanks for working on this [~shashikant]. The latest patch looks really good to
me. Some really minor comments. I am +1 on the patch after that.
1) ChunkGroupOutputStream:259,260,276,277,396,648 this is an unrelated change
2) ChunkGroupOutputStream:292-300, the TODO should be moved inside
handleCloseContainerException
3) ChunkGroupOutputStream:631 setCurrentPosition is not used, can we remove
this ?
4) ChunkOutputStream:113-114 unrelated change.
5) TestCloseContainerHandlingByClient#validateData, the input stream is not
closed here
5) TestCloseContainerHandlingByClient#waitForContainerClose, the wait for close
loop should be another loop. this will help in closing multiple container in
one iteration faster.
6) TestCloseContainerHandlingByClient#95, I feel fixedLengthString can be
removed and replaced with RandomStringUtils.random() to generate keydata, this
will help in validating with random data.
7)TestOmBlockVersioning, wildcard import
> Handle CLOSED_CONTAINER_IO exception in ozoneClient
> ---------------------------------------------------
>
> Key: HDDS-247
> URL: https://issues.apache.org/jira/browse/HDDS-247
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Blocker
> Fix For: 0.2.1
>
> Attachments: HDDS-247.00.patch, HDDS-247.01.patch, HDDS-247.02.patch,
> HDDS-247.03.patch, HDDS-247.04.patch, HDDS-247.05.patch, HDDS-247.06.patch,
> HDDS-247.07.patch, HDDS-247.08.patch, HDDS-247.09.patch, HDDS-247.10.patch
>
>
> In case of ongoing writes by Ozone client to a container, the container might
> get closed on the Datanodes because of node loss, out of space issues etc. In
> such cases, the operation will fail with CLOSED_CONTAINER_IO exception. In
> cases as such, ozone client should try to get the committed length of the
> block from the Datanodes, and update the OM. This Jira aims to address this
> issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
