[
https://issues.apache.org/jira/browse/HDFS-13861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594521#comment-16594521
]
Brahma Reddy Battula commented on HDFS-13861:
---------------------------------------------
bq.In the execution part it is case sensitive only at the end if the case was
not same as desired it won't execute and land up considering it not one of its
command and print the entire usage.
Agree. Hopefully nobody have testcase for this case-sensitive(i.e arg
validation).
{code:java}
else if ("-rm".equalsIgnoreCase(cmd)) {
if (argv.length < 2) {
System.err.println("Not enough parameters specified for cmd " + cmd);
printUsage();
return exitCode;
}{code}
bq.ii)Could be done for sure,if you suggest.It was previously like that so was
thinking to put minimal changes in terms of previous usage.But if you think i
can do that.
IMO,it's better to change to consistent with dfsadmin.(Usage: hdfs dfsadmin)
Other than this lgtm.+1
> RBF: Illegal Router Admin command leads to printing usage for all commands
> --------------------------------------------------------------------------
>
> Key: HDFS-13861
> URL: https://issues.apache.org/jira/browse/HDFS-13861
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-13861-01.patch, HDFS-13861-02.patch
>
>
> When an illegal argument is passed for any router admin command it prints
> usage for all the admin command it should be specific to the command used and
> print the usage only for that command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
