[
https://issues.apache.org/jira/browse/HDFS-13806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594734#comment-16594734
]
Sammi Chen commented on HDFS-13806:
-----------------------------------
Hi [~vinayrpet] and [~ayushtkn], thanks for reporting and working on it. The
overall idea LGTM. Just have two comments, one is a new exception class
NoECPolicySetException seems a little heavy. It's not a Hadoop tradition to
create a new exception for each specific error reason. Another is the error
message
{code:java}
+ } else {
+ throw new NoECPolicySetException(
+ "No erasure coding policy explicitly set on " + src
+ + ". Use -setPolicy -path <PATH> -replicate to enforce "
+ + "default replication policy irresptive of EC policy"
+ + " defined on parent");{code}
The message is thrown by the NN and it carries the information of an command
tool format. Usually it's better not include external tool info in NN. .
> EC: No error message for unsetting EC policy of the directory inherits the
> erasure coding policy from an ancestor directory
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-13806
> URL: https://issues.apache.org/jira/browse/HDFS-13806
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
> Affects Versions: 3.0.0
> Environment: 3 Node SUSE Linux cluster
> Reporter: Souryakanta Dwivedy
> Assignee: Ayush Saxena
> Priority: Minor
> Attachments: HDFS-13806-01.patch, HDFS-13806-02.patch,
> HDFS-13806-03.patch, No_error_unset_ec_policy.png
>
>
> No error message thrown for unsetting EC policy of the directory inherits the
> erasure coding policy from an ancestor directory
> Steps :-
> --------------
> * Create a Directory
> - Set EC policy for the Directory
> - Create a file in-side that Directory
> - Create a sub-directory inside the parent directory
> - Check both the file and sub-directory inherit the EC policy from parent
> directory
> - Try to unset EC Policy for the file and check it will throw error as [
> Cannot unset an erasure coding policy on a file]
> - Try to unset EC Policy for the sub-directory and check it will throw a
> success message as [Unset erasure coding policy from <path>]
> instead of throwing the error message,which is wrong behavior
> Actual output :-
> No proper error message thrown for unsetting EC policy of the directory
> inherits the erasure coding policy from an ancestor directory
> A success message is displayed instead of throwing an error message
> Expected output :-
>
> Proper error message should be thrown while trying to unset EC policy of the
> directory inherits the erasure coding policy from an ancestor directory
> like error message thrown while unsetting the EC policy of a file inherits
> the erasure coding policy from an ancestor directory
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
