[
https://issues.apache.org/jira/browse/HDDS-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595197#comment-16595197
]
Mukul Kumar Singh commented on HDDS-332:
----------------------------------------
Hi [~nandakumar131], thanks for updating the patch. The patch looks good to me.
I have very minor nitpicks in the current patch, which can also be handled as
part of a followup jira.
+1, pending jenkins.
1) ContainerTestHelper.java:41,46 are unused, please remove
2) ContainerTestHelper.java, the license header is not consistent
3) ObjectStoreHandler.java, the changes in the Apache License header is not
needed.
4) OzoneConsts.java:113-116 can be removed
5) TestBuckets.java:98-99 can be removed as well
6) TestCloseContainerHandlingByClient;77 can be removed too.
7) TestContainerPersistence:78, this can be removed as well.
8) TestOzoneContainerRatis:55, newOzoneConfiguration can be removed.
9) TestOzoneWebAccess:26, unused import.
10) TestRatisManager:48, newOzoneConfiguration can be removed
> Remove the ability to configure ozone.handler.type
> --------------------------------------------------
>
> Key: HDDS-332
> URL: https://issues.apache.org/jira/browse/HDDS-332
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Dinesh Chitlangia
> Assignee: Anu Engineer
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-332.001.patch, HDDS-332.002.patch,
> HDDS-332.003.patch, HDDS-332.004.patch
>
>
> Based on feedback from [~anu] and [~xyao], logging this Jira to remove the
> ability to configure ozone.handler.type.
> Currently, it can be configured with values - distributed or local.
> Value 'local' was strictly for internal testing purposes in initial stages.
> By removing the configurability, we can avoid situations where users may end
> up misconfiguring and running into issues.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
