[
https://issues.apache.org/jira/browse/HDFS-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597488#comment-16597488
]
Steve Loughran commented on HDFS-13879:
---------------------------------------
it makes sense.
# I expect everything to go near that class to have something in filesystem.md
strictly defining what it does as well as can be done, or at least precondition.
# And some contract test to go with it, though as HDFS/webhdfs is the only FS
which supports it, it's less of an issue.
The goal there is for (a) people implementing other FS clients to know what
they MUST/SHOULD do, and for people working with filesystems to know what to
expect (and complain if they don't get). I know its extra work, but iits
in HADOOP-15691 Im proposing a way to probe for an FS instance having a
feature; snapshots is one of the features the patch already supports. So: no
need for a hasSnapshots() method.
> FileSystem: Should allowSnapshot() and disallowSnapshot() be part of it?
> ------------------------------------------------------------------------
>
> Key: HDFS-13879
> URL: https://issues.apache.org/jira/browse/HDFS-13879
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Siyao Meng
> Priority: Major
>
> I wonder whether we should add allowSnapshot() and disallowSnapshot() to
> FileSystem abstract class.
> I think we should because createSnapshot(), renameSnapshot() and
> deleteSnapshot() are already part of it.
> Any reason why we don't want to do this?
> Thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
