[
https://issues.apache.org/jira/browse/HDDS-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597578#comment-16597578
]
Shashikant Banerjee commented on HDDS-372:
------------------------------------------
Thanks [~szetszwo], for the patch. Some comments inline:
1.ChunkOutputStream.java : 157 - getNextCheckName() should be
getNextChunkName()
2.OutputStreamWithBuffer.java: 51 :-> I think the condition should be offset +
length > bytes.length
3.ChunkOutputStream.java: 223 ->I think we should not rest the buffer here but
readjust it to the initial position in case the flush Fails. Resetting the
buffer will clear up the entire buffer i guess,
4. TestCloseContainerHandlingByClient.java : All the tests seem to be broken.
Can you please check these?
> There are two buffer copies in ChunkOutputStream
> ------------------------------------------------
>
> Key: HDDS-372
> URL: https://issues.apache.org/jira/browse/HDDS-372
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Client
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-372.20180829.patch
>
>
> Currently, there are two buffer copies in ChunkOutputStream
> # from byte[] to ByteBuffer, and
> # from ByteBuffer to ByteString.
> We should eliminate the ByteBuffer in the middle.
> For zero copy io, we should support WritableByteChannel instead of
> OutputStream. It won't be done in this JIRA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
