[
https://issues.apache.org/jira/browse/HDFS-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080941#comment-13080941
]
Uma Maheswara Rao G commented on HDFS-2238:
-------------------------------------------
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
(version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test
framework compile.
No tests required for this change.
FSCK Report formation result pasted in above comment.
> NamenodeFsck.toString() uses StringBuilder with + operator
> -----------------------------------------------------------
>
> Key: HDFS-2238
> URL: https://issues.apache.org/jira/browse/HDFS-2238
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-2238.patch
>
>
> We should always use StringBuilder.append(..) but not + (string
> concatenation).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
