[ 
https://issues.apache.org/jira/browse/HDDS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598751#comment-16598751
 ] 

Elek, Marton commented on HDDS-336:
-----------------------------------

Thank you very much the update [~GeLiXin]

Tested and worked well:
{code:java}
{
  "version" : 0,
  "md5hash" : null,
  "createdOn" : "Thu, 19 Feb +50635 09:14:18 GMT",
  "modifiedOn" : "Thu, 19 Feb +50635 12:23:20 GMT",
  "size" : 524288000,
  "keyName" : "file1",
  "keyLocations" : [ {
    "containerID" : 20,
    "localID" : 1535723313227,
    "length" : 134217728,
    "offset" : 0
  }, {
    "containerID" : 19,
    "localID" : 1535723319296,
    "length" : 268435456,
    "offset" : 0
  }, {
    "containerID" : 18,
    "localID" : 1535723322940,
    "length" : 121634816,
    "offset" : 0
  } ]
}{code}
 

+1 The patch also looks good to me.

Could you please fix the last two checkstyle/javadoc issues, and I will commit 
the patch... (unit test issue is not related and will be fixed by HDDS-388)
{code:java}
./hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/client/rest/response/KeyInfoDetails.java:55:
  public void setKeyLocation(List<KeyLocation> Locations) {:48: Name 
'Locations' must match pattern '^[a-z][a-zA-Z0-9]*$'. [ParameterName]

[WARNING] 
/testptch/hadoop/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/client/rest/response/KeyInfoDetails.java:55:
 warning - @param argument "keyLocations" is not a parameter name.{code}
 

> Print out container location information for a specific ozone key 
> ------------------------------------------------------------------
>
>                 Key: HDDS-336
>                 URL: https://issues.apache.org/jira/browse/HDDS-336
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: SCM
>            Reporter: Elek, Marton
>            Assignee: LiXin Ge
>            Priority: Major
>              Labels: newbie
>             Fix For: 0.2.1
>
>         Attachments: HDDS-336.000.patch, HDDS-336.001.patch, 
> HDDS-336.002.patch, HDDS-336.003.patch, HDDS-336.004.patch
>
>
> In the protobuf protocol we have all the containerid/localid(=blockid) 
> information for a specific ozone key.
> It would be a big help to print out this information to the command line with 
> the ozone cli.
> It requires to improve the REST and RPC interface with additionalOzone 
> KeyLocation information.
> It would help a very big help during the test of the current scm behaviour.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to