[
https://issues.apache.org/jira/browse/HDDS-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599793#comment-16599793
]
Dinesh Chitlangia commented on HDDS-390:
----------------------------------------
[~anu] - Yes findbug issue will be addressed depending on whether or not we
impose any criteria for keyname validity apart from URI chars. If we impose
additional checks, then the local variable will come into use, else, your
suggestion will be applied.
Regarding test failure, I am inclined not to trust the Jenkins output based on
what we have seen for HDDS-98. I will run the integration tests locally before
the next patch.
> Add method to check for valid key name based on URI characters
> --------------------------------------------------------------
>
> Key: HDDS-390
> URL: https://issues.apache.org/jira/browse/HDDS-390
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-390.001.patch
>
>
> As per design, key names composed of all valid characters in URI set must be
> treated as valid key name.
> For URI character set: [https://tools.ietf.org/html/rfc2396#appendix-A]
> This Jira proposes to define validateKeyName() similar to
> validateResourceName() that validates bucket/volume name
>
> Valid Key name must:
> * conform to URI Character set
> * must allow /
> TBD whether key names must impose other rules similar to volume/bucket names
> like -
> * should not start with period or dash
> * should not end with period or dash
> * should not have contiguous periods
> * should not have period after dash and vice versa
> etc
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
