[
https://issues.apache.org/jira/browse/HDDS-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602473#comment-16602473
]
Tsz Wo Nicholas Sze edited comment on HDDS-383 at 9/3/18 10:40 PM:
-------------------------------------------------------------------
Thanks [~shashikant].
- Should the index be set to currentStreamIndex instead of 0?
{code}
+ ListIterator<ChunkOutputStreamEntry> streamEntryIterator =
+ streamEntries.listIterator(currentStreamIndex);
+ int index = 0;
{code}
- In both discardPreallocatedBlocks(..) and removeEmptyBlocks(), the index
should not be incremented if remove(index) is called.
- How about combining locationInfoList and streamEntries into one list?
was (Author: szetszwo):
Thanks [~shashikant].
- Should the index be set to currentStreamIndex instead of 0?
{code}
+ ListIterator<ChunkOutputStreamEntry> streamEntryIterator =
+ streamEntries.listIterator(currentStreamIndex);
+ int index = 0;
{code}
- In both discardPreallocatedBlocks(..) and removeEmptyBlocks(), the index
should not be increamented if remove(index) is called.
- How about combining locationInfoList and streamEntries into one list?
> Ozone Client should discard preallocated blocks from closed containers
> ----------------------------------------------------------------------
>
> Key: HDDS-383
> URL: https://issues.apache.org/jira/browse/HDDS-383
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Fix For: 0.2.1
>
> Attachments: HDDS-383.00.patch, HDDS-383.01.patch
>
>
> When key write happens in Ozone client, based on the initial size given,
> preallocation of blocks happen. While write happens, containers can get
> closed and if the remaining preallocated blocksĀ belong to closed containers
> , they can be discarded right away instead of trying to write these blocks
> and failing with exception. This Jira aims to address this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]