[ 
https://issues.apache.org/jira/browse/HDDS-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604514#comment-16604514
 ] 

Nanda kumar commented on HDDS-400:
----------------------------------

Thanks [~elek] for the patch. I agree with [~ajayydv] on this. Instead of 
iterating through all the containers from the report, we can handle this in 
{{DeadNodeHandler}}. We are already removing the replica from 
{{containerStateManager}}, we just have to emit 
{{SCMEvents.REPLICATE_CONTAINER}} event if existingReplicas doesn't match with 
expectedReplicas.

> Check global replication state of the reported containers on SCM
> ----------------------------------------------------------------
>
>                 Key: HDDS-400
>                 URL: https://issues.apache.org/jira/browse/HDDS-400
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: SCM
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Blocker
>             Fix For: 0.2.1
>
>         Attachments: HDDS-400.001.patch, HDDS-400.002.patch
>
>
> Current container replication handler compare the reported containers with 
> the previous report. It handles over an under replicated state.
> But there is no logic to check the cluster-wide replication count. If a node 
> is went down it won't be detected.
> For the sake of simplicity I would add this check to the 
> ContainerReportHandler (as of now). So all the reported container should have 
> enough replicas. 
> We can check the performance implication with genesis, but as a first 
> implementation I think it could be good enough. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to