[ 
https://issues.apache.org/jira/browse/HDDS-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605085#comment-16605085
 ] 

Anu Engineer commented on HDDS-351:
-----------------------------------

 Thanks for updating the patch. some very minor comments.

* MiniOzoneClusterImpl.java#shutdown - Looks like we delete a bunch of 
directotries and then call stop(). Shouldn't stop be done before delete 
operation?
* TestSCMChillModeManager.java# private static double chillModeCutoff; -- 
unused variable.
* TestUtils.java
    -- Line length -- CheckStyle will fail.
    -- Is there a reason why we don't use imports? and use smaller names in 
code ?  
    org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo

 

> Add chill mode state to SCM
> ---------------------------
>
>                 Key: HDDS-351
>                 URL: https://issues.apache.org/jira/browse/HDDS-351
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>             Fix For: 0.2.1
>
>         Attachments: HDDS-351.00.patch, HDDS-351.01.patch, HDDS-351.02.patch, 
> HDDS-351.03.patch, HDDS-351.04.patch, HDDS-351.05.patch, HDDS-351.06.patch, 
> HDDS-351.07.patch
>
>
> Add chill mode state to SCM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to