[
https://issues.apache.org/jira/browse/HDFS-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606248#comment-16606248
]
Erik Krogen commented on HDFS-13791:
------------------------------------
Thanks [~csun], I think your idea about "named" log statements makes sense. I
additionally defined one as a "primary", and others follow along afterwards.
Without this, given unfortunate timing, "post" could trigger the logging (at
time T0) even though "pre" wasn't logged, which would then trigger the _next_
"pre" (time T0 + Td) but not the next "post" (time T0 + Td). That situation
isn't what we want; we always want a "pre" followed by the corresponding "post".
I've attached v003 patch which now has all of the Javadoc and unit tests. I
additionally created HADOOP-15726 for the trunk patch. If v003 looks good to
you I'll begin splitting it up.
> Limit logging frequency of edit tail related statements
> -------------------------------------------------------
>
> Key: HDFS-13791
> URL: https://issues.apache.org/jira/browse/HDFS-13791
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs, qjm
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HDFS-13791-HDFS-12943.000.patch,
> HDFS-13791-HDFS-12943.001.patch, HDFS-13791-HDFS-12943.002.patch
>
>
> There are a number of log statements that occur every time new edits are
> tailed by a Standby NameNode. When edits are tailing only on the order of
> every tens of seconds, this is fine. With the work in HDFS-13150, however,
> edits may be tailed every few milliseconds, which can flood the logs with
> tailing-related statements. We should throttle it to limit it to printing at
> most, say, once per 5 seconds.
> We can implement logic similar to that used in HDFS-10713. This may be
> slightly more tricky since the log statements are distributed across a few
> classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
