[ 
https://issues.apache.org/jira/browse/HDFS-13880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606386#comment-16606386
 ] 

Erik Krogen commented on HDFS-13880:
------------------------------------

Hey [~vagarychen], v002 looks really great!
 * In the Javadoc for {{AlignmentContext#isCoordinatedCall()}}, there should be 
an empty line between the body of text and the first {{@param}} tag.
 * In {{ipc.Server}} L2537, we assume the request is Protobuf. I think it's 
probably fine not to perform correctly if a {{Writable}} comes along, but we 
should at least check that it is in fact using Protobuf (to avoid a 
{{ClassCastException}}).
 * It seems the test could be improved from its current state of being brittle 
(time-dependent) and slow. I am thinking something like:
 ** Set the edit tail frequency very high to be sure it won't happen unless we 
trigger it manually
 ** In thread A, submit the blocking call (msync needed)
 ** In thread B, wait a little, then manually trigger the edit tail
 ** Confirm that thread A was able to complete its call
 * Why isn't {{getContentSummary}} coordinated?

> Add mechanism to allow certain RPC calls to bypass sync
> -------------------------------------------------------
>
>                 Key: HDFS-13880
>                 URL: https://issues.apache.org/jira/browse/HDFS-13880
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Major
>         Attachments: HDFS-13880-HDFS-12943.001.patch, 
> HDFS-13880-HDFS-12943.002.patch, HDFS-13880-HDFS-12943.003.patch
>
>
> Currently, every single call to NameNode will be synced, in the sense that 
> NameNode will not process it until state id catches up. But in certain cases, 
> we would like to bypass this check and allow the call to return immediately, 
> even when the server id is not up to date. One case could be the to-be-added 
> new API in HDFS-13749 that request for current state id. Others may include 
> calls that do not promise real time responses such as {{getContentSummary}}. 
> This Jira is to add the mechanism to allow certain calls to bypass sync.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to