[
https://issues.apache.org/jira/browse/HDFS-13869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607316#comment-16607316
]
Íñigo Goiri commented on HDFS-13869:
------------------------------------
{{TestDisableRouterQuota}} looks like a weird place to test this.
I guess the reason is failing there is because we didn't start the metrics
system there.
I think this test makes more sense somewhere like {{TestRouter}}.
A couple nits:
* Avoid the extra line breaks at NamenodeBeanMetrics#186 and Router#565.
* Typo in TestDisableRouterQuota#89 ("becuase").
* It's weird that one returns "metrics is not initialized" and the other
"Metrics is not initialized". Actually, we should try to distinguish the two
cases; they should be different cases.
> RBF: Handle NPE for NamenodeBeanMetrics#getFederationMetrics()
> --------------------------------------------------------------
>
> Key: HDFS-13869
> URL: https://issues.apache.org/jira/browse/HDFS-13869
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.0.0
> Reporter: Surendra Singh Lilhore
> Assignee: Ranith Sardar
> Priority: Major
> Attachments: HDFS-13869-002.diff, HDFS-13869-003.diff,
> HDFS-13869-004.patch, HDFS-13869.patch
>
>
> {code:java}
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.server.federation.metrics.NamenodeBeanMetrics.getUsed(NamenodeBeanMetrics.java:205)
> at
> org.apache.hadoop.hdfs.server.federation.metrics.NamenodeBeanMetrics.getCapacityUsed(NamenodeBeanMetrics.java:519)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43){code}
> ngMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
