[
https://issues.apache.org/jira/browse/HDFS-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082264#comment-13082264
]
Uma Maheswara Rao G commented on HDFS-2237:
-------------------------------------------
Hi Nicholas,
I have gone through the changes.
Patch looks good to me.
Looks patch could not be applied any more to trunk. You may need to regenerate.
I have small nit:
can we convert comments to javadoc comments in UnderReplicatedBlocks.java?.
/* return an iterator of all the under replication blocks */
public synchronized BlockIterator iterator() {
return new BlockIterator();
}
--Thanks
> Change UnderReplicatedBlocks from public to package private
> -----------------------------------------------------------
>
> Key: HDFS-2237
> URL: https://issues.apache.org/jira/browse/HDFS-2237
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: h2237_20110808.patch, h2237_20110808b.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
