[
https://issues.apache.org/jira/browse/HDFS-13906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611037#comment-16611037
]
Íñigo Goiri commented on HDFS-13906:
------------------------------------
Thanks [~ayushtkn] for [^HDFS-13906-01.patch].
The fix looks good, just a couple aesthetic comments from my side:
* Remove extra line in TestRouterAdminCLI#634.
* When creating the new spaces, I would use src1, src2, dest1, and dest2.
* Add a couple comments in between to split the unit test for
{{testMultiArgsRemoveMountTable}}. For example, one part to add the mount
points, another block to check them and another block to remove them and check.
* Similar for the quota one.
Let's see what Yetus says too, there might be some checkstyle too.
> RBF: Add multiple paths for dfsrouteradmin "rm" and "clrquota" commands
> -----------------------------------------------------------------------
>
> Key: HDFS-13906
> URL: https://issues.apache.org/jira/browse/HDFS-13906
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: federation
> Reporter: Soumyapn
> Assignee: Ayush Saxena
> Priority: Major
> Labels: RBF
> Attachments: HDFS-13906-01.patch
>
>
> Currently we have option to delete only one mount entry at once.
> If we have multiple mount entries, then it would be difficult for the user to
> execute the command for N number of times.
> Better If the "rm" and "clrQuota" command supports multiple entries, then It
> would be easy for the user to provide all the required entries in one single
> command.
> Namenode is already suporting "rm" and "clrQuota" with multiple destinations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
