[
https://issues.apache.org/jira/browse/HDDS-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612430#comment-16612430
]
Lokesh Jain edited comment on HDDS-419 at 9/12/18 4:35 PM:
-----------------------------------------------------------
[~msingh] Thanks for working on this! Please find my comments below.
# ChunkGroupInputStream: 118-123 - I agree with [~xyao] and [~ajayydv].
Ideally we should not have a case where actualLen not equal to readLen. But in
case we encounter such a scenario we should log it. We should also throw an
exception in such a case. This can only occur if one of the chunk entry gives
an incorrect length or if chunk file is truncated.
# We can also rename readLen and actualLen to numBytesToRead and numBytesRead
respectively or some better names.
was (Author: ljain):
[~msingh] Thanks for working on this! Please find my comments below.
# ChunkGroupInputStream: 118-123 - I agree with [~xyao] and [~ajayydv].
Ideally we should not have a case where the number of bytes read is not equal
to number of bytes to read. But in case we encounter such a scenario we should
log it. We should also throw an exception in such a case. This can only occur
if one of the chunk entry gives an incorrect length or if chunk file is
truncated.
# We can also rename readLen and actualLen to numBytesToRead and numBytesRead
respectively or some better names.
> ChunkInputStream bulk read api does not read from all the chunks
> ----------------------------------------------------------------
>
> Key: HDDS-419
> URL: https://issues.apache.org/jira/browse/HDDS-419
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Affects Versions: 0.2.1
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Blocker
> Fix For: 0.2.1
>
> Attachments: HDDS-419.001.patch
>
>
> After enabling of bulk reads with HDDS-408, testDataValidate started failing
> because the bulk read api does not read all the chunks from the block.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
