[
https://issues.apache.org/jira/browse/HDFS-13778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612927#comment-16612927
]
Konstantin Shvachko edited comment on HDFS-13778 at 9/13/18 1:44 AM:
---------------------------------------------------------------------
Plamen, like your changes. Looks good.
* -I see you updated the package name, but didn't move the file in the
directory tree. Glad you didn't, otherwise I wouldn't see the diff.-
You did move the file - my IDE messed up, still. I am actually fine with the
test being in {{org.apache.hadoop.hdfs}} because we are testing mostly the
client logic here rather the server. Well both, but from client perspective. I
suggest we leave the package as is for now to see the diff in the commit. If
you decide to move it under {{org.apache.hadoop.hdfs.server.ha}} let's do a
separate jira just for the move.
* Jenkins says there is a space in {{runClientsWithFailover()}}
* I agree chasing {{testClientSendsState}} with reflections etc. is not
productive. Better time spent implementing some of the test cases from the test
plan.
was (Author: shv):
Plamen, like your changes. Looks good.
* I see you updated the package name, but didn't move the file in the directory
tree. Glad you didn't, otherwise I wouldn't see the diff. I am actually fine
with the test being in {{org.apache.hadoop.hdfs}} because we are testing mostly
the client logic here rather the server. Well both, but from client
perspective. I suggest we leave the package as is for now to see the diff in
the commit. If you decide to move it under {{org.apache.hadoop.hdfs.server.ha}}
let's do a separate jira just for the move.
* Jenkins says there is a space in {{runClientsWithFailover()}}
* I agree chasing {{testClientSendsState}} with reflections etc. is not
productive. Better time spent implementing some of the test cases from the test
plan.
> In TestStateAlignmentContextWithHA replace artificial
> AlignmentContextProxyProvider with real ObserverReadProxyProvider.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-13778
> URL: https://issues.apache.org/jira/browse/HDFS-13778
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Konstantin Shvachko
> Assignee: Sherwood Zheng
> Priority: Major
> Attachments: HDFS-13778-HDFS-12943.001.patch,
> HDFS-13778-HDFS-12943.002.patch, HDFS-13778-HDFS-12943.003.patch
>
>
> TestStateAlignmentContextWithHA uses an artificial
> AlignmentContextProxyProvider, which was temporary needed for testing. Now
> that we have real ObserverReadProxyProvider it can take over ACPP. This is
> also useful for testing the ORPP.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
