[ https://issues.apache.org/jira/browse/HDDS-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613937#comment-16613937 ]
Xiaoyu Yao commented on HDDS-419: --------------------------------- Thanks [~ljain] for working on this. Patch v2 looks good to me. Just few minor issues, +1 after them being fixed. ChunkGroupInputStream.java Line 125: blockID= should be blockID=%s, blockSize => length Line 130/131: NIT: prefer to use numBytesRead though they are the same. StringUtils.java Line 746: NIT: unrelated fix that can be tracked with separate Jira > ChunkInputStream bulk read api does not read from all the chunks > ---------------------------------------------------------------- > > Key: HDDS-419 > URL: https://issues.apache.org/jira/browse/HDDS-419 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Client > Affects Versions: 0.2.1 > Reporter: Mukul Kumar Singh > Assignee: Lokesh Jain > Priority: Blocker > Fix For: 0.2.1 > > Attachments: HDDS-419.001.patch, HDDS-419.002.patch > > > After enabling of bulk reads with HDDS-408, testDataValidate started failing > because the bulk read api does not read all the chunks from the block. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org