[
https://issues.apache.org/jira/browse/HDDS-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614290#comment-16614290
]
Dinesh Chitlangia edited comment on HDDS-394 at 9/14/18 3:02 AM:
-----------------------------------------------------------------
[~anu] I started modifying DatanodeContainerProtocol.proto
[^proto.diff] shows what my changes.
I am only concerned about the following segment:
{noformat}
message PutSmallFileRequestProto {
- required PutKeyRequestProto key = 1;
+ required PutBlockRequestProto block = 1;
required ChunkInfo chunkInfo = 2;
required bytes data = 3;
}
@@ -416,7 +416,7 @@ message PutSmallFileResponseProto {
}
message GetSmallFileRequestProto {
- required GetKeyRequestProto key = 1;
+ required GetBlockRequestProto block = 1;
}
{noformat}
In this segment, I changed key --> bucket, I want to ensure this is the correct
interpretation, as the word _key_ is omnipresent in ozone with contextual
meaning :)
Could you please review my base changes and then I will go ahead and build and
make the changes across the ecosystem?
Thank you.
was (Author: dineshchitlangia):
[~anu] I started modifying DatanodeContainerProtocol.proto
[^proto.diff] shows what my changes.
I am only concerned about the following segment:
{noformat}
message PutSmallFileRequestProto {
- required PutKeyRequestProto key = 1;
+ required PutBlockRequestProto block = 1;
required ChunkInfo chunkInfo = 2;
required bytes data = 3;
}
@@ -416,7 +416,7 @@ message PutSmallFileResponseProto {
}
message GetSmallFileRequestProto {
- required GetKeyRequestProto key = 1;
+ required GetBlockRequestProto block = 1;
}
{noformat}
In this segment, I changed key --> bucket, I want to ensure this is the correct
interpretation. As the word key is omnipresent in ozone with contextual meaning
:)
Could you please review my base changes and then I will go ahead and build and
make the changes across the ecosystem?
Thank you.
> Rename *Key Apis in DatanodeContainerProtocol to *Block apis
> ------------------------------------------------------------
>
> Key: HDDS-394
> URL: https://issues.apache.org/jira/browse/HDDS-394
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Mukul Kumar Singh
> Assignee: Dinesh Chitlangia
> Priority: Major
> Attachments: proto.diff
>
>
> All the block apis in client datanode interaction are named *key apis(e.g.
> PutKey), This can be renamed to *Block apis. (e.g. PutBlock).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
