[
https://issues.apache.org/jira/browse/HDDS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618160#comment-16618160
]
Xiaoyu Yao commented on HDDS-366:
---------------------------------
Thanks [~ajayydv] for working on this. The patch looks good to me overall.
Here are some feedbacks:
ContainerMapping.java
As mentioned in the description, this patch is intended to precheck chillmode
for client RPC ops. Have you consider move the check from internal class
ContainerMapping.java to SCMClientProtocolServer.java just before the
adminAcess check or even refactor the adminAccess check to reuse the PreCheck
interface? I understand that there are multiple callers of ContainerMapping
class methods. However, I think we should fix with explicit scmOp checks as you
have defined in hdds.proto for block protocols.
SCMNodeManager.java
Line 491-496: NIT: unused wrapper can be removed.
SCMChillModeManager.java
Line 238: createReplicationPipeline the client RPC does not handle the pipeline
creation. It is part of internal scm container allocation operation.**
> Update functions impacted by SCM chill mode in
> StorageContainerLocationProtocol
> -------------------------------------------------------------------------------
>
> Key: HDDS-366
> URL: https://issues.apache.org/jira/browse/HDDS-366
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-366.00.patch
>
>
> Modify functions impacted by SCM chill mode in
> StorageContainerLocationProtocol.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
