[
https://issues.apache.org/jira/browse/HDFS-11719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618253#comment-16618253
]
Mingliang Liu commented on HDFS-11719:
--------------------------------------
Failing tests are not related. This is to fix bug of using API and does not
change checksum logic so existing unit tests are enough.
I'll hold on 1 day to commit in case people have more comments.
> Arrays.fill() wrong index in BlockSender.readChecksum() exception handling
> --------------------------------------------------------------------------
>
> Key: HDFS-11719
> URL: https://issues.apache.org/jira/browse/HDFS-11719
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Tao Zhang
> Assignee: Tao Zhang
> Priority: Major
> Attachments: HADOOP-11719.001.patch, HADOOP-11719.002.patch,
> HADOOP-11719.003.patch
>
>
> In BlockSender.readChecksum() exception handling part:
> Arrays.fill(buf, checksumOffset, checksumLen, (byte) 0);
> Actually the paramters should be: Arrays.fill(buf, <startIndex>, <endIndex>,
> value);
> So it should be changed to:
> Arrays.fill(buf, checksumOffset, checksumOffset + checksumLen, (byte) 0);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
